Setting for max-inline-size does not work

[Thomas-Harrell]

Bug Report

Web version: In the settings in Font and Layout - Layout - Page - Maximum Block Size/Maximum Inline Size, the numerical setting does not take effect, and after refreshing the page, the value resets.

Suggestions

Naming related: Fonts and Layout > Preferences. Would this be more concise?

Regarding keyboard shortcuts: Integrate the Wiki Shortcuts into “Preferences (tentative) > Shortcuts.” This would make it more convenient and straightforward to see which shortcuts are available, and perhaps allow for editing them as well.

[chrox]

Suggestions:

1. Please open one issue for one bug or one feature request so that we can properly track the issues list.
2. Please use English to open issue or feature request in the Readest community in GitHub so that more people could join the discussions and share their thoughts. Do not use other languages here.

[chrox]

As for the suggestions, there will be another settings/preferences page for more generic settings for the APP so the font/layout configs will still be there for more specific reading configs. A vimium keybinding is planned, accessible via the Shift + / shortcut. It won’t have its own dedicated page, as it’s designed to remain unseen for users who don’t utilize keybindings. The UI should focus on presenting only the functions users actively need, rather than exposing all features to everyone.

[Thomas-Harrell]

@chrox

Oh, thank you for the reminder.

I used Chinese to write because I know developers can also use Chinese.

[chrox]

Absolutely. Using English is more convenient as it’s used among more developers. Thank you for understanding.

[Thomas-Harrell]

@chrox

Regarding providing feedback in English:

Since I am using the web version, and the web version doesn't have an option to switch languages, I’m not sure what the exact English names for some of the function buttons are.

[eg9y]

I was only able to reproduce the Max Block Size not persisting. Reproduction steps:

1. Go to Readest Web
2. choose ebook
3. Font & Layout
4. Layout
5. Set Maximum Block Size to any value greater than 500 and less than 9999
6. Close settings
7. Open Font & Layout again
8. Notice the Maximum Block Size switched back to 500

To fix, I persisted the maxBlockSize state via this PR:

#134

[eg9y]

In addition, I noticed an out-of-scope issue where number inputs would generate a "NaN" text when typing a non-numeric input (apps/readest-app/src/app/reader/components/settings/NumberInput.tsx). @chrox

[chrox]

In addition, I noticed an out-of-scope issue where number inputs would generate a "NaN" text when typing a non-numeric input (apps/readest-app/src/app/reader/components/settings/NumberInput.tsx). @chrox

Ah, non-numeric input in NumberInput should be handled properly. I find it annoying to delete the NaN text. So invalid number from non-numeric char should not be set into the input field. Could you fix this? Thanks.