fix(tts): skip br elements in PDF text layer to prevent TTS interruptions, closes #3771#3811
Merged
fix(tts): skip br elements in PDF text layer to prevent TTS interruptions, closes #3771#3811
Conversation
chrox
force-pushed
the
fix/tts-pdf-line-breaks-3771
branch
3 times, most recently
from
65fa4e3 to
d35952c
Compare
…ions at line breaks, closes #3771 PDF.js TextLayer renders <br> between text spans for visual line wrapping. The TTS SSML generator was converting these to <break> elements, causing TTS engines to pause at every PDF line break within paragraphs. Fix by rejecting <br> (along with canvas and annotationLayer) via the node filter when the document is detected as a PDF. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chrox
force-pushed
the
fix/tts-pdf-line-breaks-3771
branch
from
d35952c to
493c808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<br>elements between text spans for visual line wrapping within paragraphs<break>elements, causing TTS engines to pause at every PDF line break.textLayerpresence) and addsbr,canvas, andannotationLayerto the node filter reject list, preventing spurious SSML breaksTest plan
<br>elements in PDF text layers don't produce SSML<break>elements🤖 Generated with Claude Code