fix: restore main library window when going to library from reader#3973
Merged
Conversation
…loses #3969 When the main window has been destroyed (Windows/Linux default close), the reader's "go to library" button only closed the reader, leaving no library visible. Add ensureMainLibraryWindow() that shows an existing main window or recreates one with the 'main' label so the existing close-reader-window wiring keeps working. Also grant the cross-window show/unminimize permissions the call now needs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleCloseBooksToLibraryinReaderContent.tsxcalledcurrentWindow.close()without ensuring a library window existed. The Rust setup hides the main window on close only on macOS; on Windows/Linux it's destroyed.ensureMainLibraryWindow(appService)insrc/utils/nav.ts. If a'main'-labelled window exists, it's shown / unminimized / focused; if it was destroyed, a new window with the'main'label is created at/library(mirroringcreateReaderWindowoptions) so the existingemitTo('main', 'close-reader-window', ...)wiring keeps working.core:window:allow-showandcore:window:allow-unminimizeso the reader window can call these on the main window.Test plan
pnpm test— 3280 passed (added 2 unit tests forensureMainLibraryWindow)pnpm lint— clean🤖 Generated with Claude Code