fix(i18n): localize quota reset countdown time units#4104
Merged
Conversation
The "Resets in {{duration}}" indicator on the user page formatted its
duration via dayjs with literal "[hr]" / "[min]" tokens, which bypassed
i18n entirely. Non-English locales rendered mixed strings like
"18 hr 6 min后重置".
Move the unit literals into the translation key itself
("Resets in {{hours}} hr {{minutes}} min") so each locale controls word
order and unit abbreviations, and translate the new key for all 33
shipped locales.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dayjs.duration().format('H [hr] m [min]'), baking Englishhr/minliterals into the rendered string. Non-English locales got mixed output like18 hr 6 min后重置.Resets in {{hours}} hr {{minutes}} min— so each locale controls word order and abbreviation. Compute hours/minutes inline; drop the unuseddayjs/@/utils/timeimports inQuota.tsx.{{hours}} 小时 {{minutes}} 分钟后重置, etc.);pnpm i18n:extractremoved the now-unusedResets in {{duration}}key.Test plan
pnpm test(4096 passed)pnpm lint18 小时 6 分钟后重置🤖 Generated with Claude Code