Gradle Version, TargetSdk, CompileSdk Upgraded and VersionCatalogs Implemented #265
Conversation
svlilyas
commented
Aug 22, 2022
svlilyas
commented
- Gradle version upgraded to 7.4.2 and Android Gradle Plugin upgraded to 7.2.2
- TargetSdk and CompileSdk upgraded to 32
- buildSrc added to manage Plugins and common Android Configs
- VersionCatalogs implemented with TOML file
- TOML file updated
Gradle upgraded to version 7.4.2 and Android Gradle Plugin Upgraded to version 7.2.2
test-app version, targetSdk, compileSdk upgraded
streamer library dependencies upgrade
opds library dependencies upgraded
navigator-media2 library dependencies upgraded.
libraries upgraded
…ed TOML Version Catalogs. Added buildSrc to manage Android Configs from one place and implemented TOML Version Catalogs.
TOML library implementation
AndroidConfig variables used in gradles
mickael-menu
left a comment
mickael-menu
left a comment
There was a problem hiding this comment.
@svlilyas Thank you for taking the time to submit a PR, there's good stuff in it. However, please open an issue (or a Slack message) first next time to discuss the changes, to make sure you don't waste your time on work that won't be accepted.
I left a few comments, but could you also rebase your changes to merge the PR onto the develop branch? We only merge hotfixes on main, any other changes must be on develop.
|
I could not able to find rebase settings. Can you tell me how to do it? |
|
I changed the base branch of your PR to |
|
@svlilyas Looks like Android Studio Dolphin has better support for TOML version catalogs 👍 |
2 participants
