Skip to content

Make ContentService.content not nullable #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Make ContentService.content not nullable #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...shared/src/main/java/org/readium/r2/shared/publication/services/content/ContentService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ interface ContentService : Publication.Service {
* The implementation must be fast and non-blocking. Do the actual extraction inside the
* [Content] implementation.
*/
fun content(start: Locator?): Content?
fun content(start: Locator?): Content
}

/**
Expand Down Expand Up @@ -64,8 +64,8 @@ class DefaultContentService(
}
}

override fun content(start: Locator?): Content? {
val publication = publication() ?: return null
override fun content(start: Locator?): Content {
val publication = publication() ?: throw IllegalStateException("No Publication object")
return ContentImpl(publication, start)
}

Expand Down