Skip to content

Conversation

@mickael-menu
Copy link
Member

@mickael-menu mickael-menu commented Jan 20, 2023

  • Fix a regression of Fix turning pages with an odd count of columns #14. The pageWidth was not calculated yet when checking for the virtual column.
  • Remove WebView listener on page fragment view destruction.
  • Set the minimum value for all range settings to 0. It's left to the host app to choose a sane range (or not for maximum user control).
    Except for:
    • fontSize: 0 makes the text disappear and breaks the pagination.
    • lineHeight: <1 makes the lines overlap which is not readable.
    • typeScale: <1 makes the headers smaller than body, which doesn't make sense.
    Screenshot 2023-01-20 at 10 45 06

@mickael-menu mickael-menu requested a review from qnga January 20, 2023 09:59
mickael-menu added a commit to demarque/readium-kotlin-toolkit that referenced this pull request Jan 20, 2023
@mickael-menu mickael-menu merged commit e44c60b into develop Jan 20, 2023
@mickael-menu mickael-menu deleted the adjust-settings branch January 20, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants