Skip to content

Conversation

@mickael-menu
Copy link
Member

Opening an external link in an EPUB failed if Chrome Custom Tabs were disabled on the device.

@mickael-menu mickael-menu requested a review from qnga November 5, 2021 10:59
)
@Retention(AnnotationRetention.BINARY)
@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION, AnnotationTarget.TYPEALIAS, AnnotationTarget.PROPERTY)
annotation class InternalReadiumApi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got inspired by InternalCoroutinesApi.

@mickael-menu mickael-menu merged commit 7b64b93 into develop Nov 8, 2021
@mickael-menu mickael-menu deleted the fix/external-links branch November 8, 2021 10:06
mickael-menu added a commit to demarque/readium-kotlin-toolkit that referenced this pull request Nov 8, 2021
commit b6b41ee
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon Nov 8 18:37:21 2021 +0100

    Add `EdgeTapNavigation` to trigger page turns on edge taps

commit b5b2b73
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon Nov 8 12:20:25 2021 +0100

    Fix OutOfMemoryError during media type sniffing (readium#44)

commit 7b64b93
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon Nov 8 11:06:52 2021 +0100

    Add a fallback when Chrome Custom Tabs are not available (readium#43)

commit 01a88a8
Author: qnga <32197639+qnga@users.noreply.github.com>
Date:   Thu Nov 4 14:37:22 2021 +0100

    Enable source and doc publishing (readium#42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants