Skip to content

Allow uses of Try with nullable error types (Try<S, F?>) #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Allow uses of Try with nullable error types (Try<S, F?>) #546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readium/shared/src/main/java/org/readium/r2/shared/util/Try.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public sealed class Try<out Success, out Failure> {
public inline fun <F> mapFailure(transform: (value: Failure) -> F): Try<Success, F> =
when (this) {
is Try.Success -> success(value)
is Try.Failure -> failure(transform(failureOrNull()!!))
is Try.Failure -> failure(transform(failureOrNull()))
}

/**
Expand All @@ -81,7 +81,7 @@ public sealed class Try<out Success, out Failure> {
): R =
when (this) {
is Try.Success -> onSuccess(value)
is Try.Failure -> onFailure(failureOrNull()!!)
is Try.Failure -> onFailure(failureOrNull())
}

/**
Expand All @@ -98,7 +98,7 @@ public sealed class Try<out Success, out Failure> {
* Returns the original [Try] unchanged.
*/
public inline fun onFailure(action: (exception: Failure) -> Unit): Try<Success, Failure> {
if (this is Try.Failure) action(failureOrNull()!!)
if (this is Try.Failure) action(failureOrNull())
return this
}
}
Expand Down