Fix building with Kotlin 1.6 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
commented
Nov 22, 2021
Comment on lines
+319
to
321
| // FIXME: To remove after bumping to Kotlin 1.6 | ||
| @Suppress("DEPRECATION") | ||
| val data = network.fetch(url, timeout = Duration.seconds(5)) |
Member
Author
There was a problem hiding this comment.
I couldn't find any API to create a Duration in seconds that doesn't give a deprecation warning either on Kotlin 1.5 or 1.6... Since we have the android.kotlinOptions.allWarningsAsErrors flag on in build.gradle, we need to suppress the deprecation warning for now to be able to build.
qnga
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
This doesn't bump the minimum required Kotlin version to 1.6, but fixes any build issue if someone chooses to use it.