Skip to content

Conversation

@stevenzeck
Copy link
Contributor

@stevenzeck stevenzeck commented Dec 20, 2021

This PR migrates the Gradle files from Groovy to Kotlin DSL.

@stevenzeck
Copy link
Contributor Author

@mickael-menu Feel free to do a pre-review while in Draft state.

@stevenzeck stevenzeck marked this pull request as ready for review December 22, 2021 05:45
@stevenzeck
Copy link
Contributor Author

This is as good as it's going to get for now. Per discussion in Slack, eventually we want to use a centralized versioning system so that any modules that depend on the same libraries all reference the same version. See https://docs.gradle.org/current/userguide/platforms.html#sub:central-declaration-of-dependencies.

The wild card is Dokka. It runs locally, so we'll have to see what it does when it goes through CI.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@mickael-menu mickael-menu merged commit 4b61ad5 into readium:develop Dec 24, 2021
@mickael-menu mickael-menu deleted the kotlin-dsl branch December 24, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants