Add page margins to user settings

[aferditamuriqi]

we need to move page margin into main settings if those are not publisher dependent.

[JayPanoz]

So yeah I can confirm they are totally publisher-independent, since we override publishers’ margin and padding for both the html element and the body element, and define our own (especially padding instead of using column-gap through the CSS --RS__pageGutter variable).

That being said, it is currently categorized as “Chrome Advanced” so the settings listed are advanced in some way, but not publishers-dependent (contrary to text-align for instance, which requires the “advanced setting flag”). So we have other advanced settings (esp. number of columns) behaving as page margin. As stated is the doc, “this classification might change and additional items be added in the future” because it kinda was an artificial one at the time it was created.

This is probably something we can discuss during the next call, UX-wise. It made a lot of sense when designing the user settings (selectors, declaration, !important, etc.) but it should also work for implementers, and maybe we can either refine it, or provide stronger guidance UX-wise e.g. “This can be in the main panel of user settings or the advanced one”, “this is not meant to be in the main panel”, etc.).

[JayPanoz]

Out of curiosity, I took a quick look at the elephant in the room, who doesn’t have advanced settings per se but offer users page margin and columns settings.

I think it would not be unexpected to find those ones in the main panel, after the usual user settings (font-size, font-family, reading modes…).

Note the columns setting is only displayed in landscape, which is something we should do as well.

That can at least serve as food for thought.

[HadrienGardeur]

I'm not sure why this is in the Epic for the new approach to user settings (#67).

[mickael-menu]

I agree with @JayPanoz that page margins (and also columns which don't require publisher's styles off) are a good fit for the advanced settings panel.

But maybe there's a case for renaming --USER__advancedSettings into --USER__publisherStyles in Readium CSS.

I'm closing this issue but feel free to reopen if there was no clear consensus.