Add NavigatorDelegate.navigator(_:didJumpTo:) API
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Navigator
NavigatorDelegate.navigator(_:didJumpTo:)API is called every time the navigator jumps to an explicit location, which might break the linear reading progression.Navigator.go(to:), but not when turning pages.Note: This is a quickfix for the shortcomings of the current Navigator API which can't be used to build a navigation history. In the future navigator I think we should emit more information about a navigation event, such as the source (link clicked,
go()call, page turned, skip forward, etc.).Twin PR: readium/kotlin-toolkit#60