-
Notifications
You must be signed in to change notification settings - Fork 184
Swift UI initial start #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note you need to add https://github.com/groue/GRDBQuery/ as a SPM dependency in the testapp until project.yml files are updated
TestApp/Sources/Resources/Assets.xcassets/defaultCover.imageset/Contents.json
Outdated
Show resolved
Hide resolved
TestApp/Sources/Views/Catalogs/CatalogDetail/CatalogDetail.swift
Outdated
Show resolved
Hide resolved
Remove default book cover, Move OPDS feed insert block into Repository, Move all database calls into Repository
TestApp/Sources/Data/Catalog.swift
Outdated
| } | ||
| } | ||
|
|
||
| func deleteCatalogs(ids: [Catalog.Id]) async throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickael-menu can we keep this or refactor to however you want it? It will be used at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erm sorry, I missed your comment before merging the PR. This should be easy to reintroduce when we'll use it.
mickael-menu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for kickstarting the SwiftUI rewrite!
This is an initial start of rewriting the TestApp using SwiftUI. Not much works at the moment, but I wanted to start putting things together so others can contribute.
What's been done
What you need to do
make dev@UIApplicationMaininAppDelegate.swiftand uncomment@maininTestApp.swift