SwiftUI Updates #65
Merged
SwiftUI Updates #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I marked this as ready for review. Everything under "Left to do" will be a next PR. @mickael-menu @gatamar any feedback would be welcomed, especially |
gatamar
reviewed
Jul 11, 2022
gatamar
reviewed
Jul 11, 2022
mickael-menu
requested changes
Jul 14, 2022
mickael-menu
approved these changes
Jul 18, 2022
Member
mickael-menu
left a comment
mickael-menu
left a comment
There was a problem hiding this comment.
Thank you, one step closer to full SwiftUI! 🔥
stevenzeck
added a commit
to stevenzeck/swift-toolkit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more screens and functionality to the TestApp using SwiftUI:
Notes
PublicationandGroupare both nowIdentifiableListformat (where it has the chevron arrow). This is becauseLazyVGridandLazyHGriddon't lazy load items when they're nested in aList, so the links are plain links and the entire catalog detail screen is in aScrollViewLeft to do