Skip to content

Implement parsing of the <id> element in OPDS 1.x feeds #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
Merged

Implement parsing of the <id> element in OPDS 1.x feeds #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07f3a99
Parse feed identifier
x0000ff Oct 14, 2025
c2321a5
Merge branch 'develop' into feature/parse-feed-id-for-opds-1.0
mickael-menu Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Sources/OPDS/OPDS1Parser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ public class OPDS1Parser: Loggable {
}
let feed = Feed(title: title)

feed.metadata.identifier = root.firstChild(tag: "id")?.stringValue

if let tmpDate = root.firstChild(tag: "updated")?.stringValue,
let date = tmpDate.dateFromISO8601
{
Expand Down
1 change: 1 addition & 0 deletions Sources/Shared/OPDS/OpdsMetadata.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import Foundation
/// OPDS metadata properties.
public class OpdsMetadata {
public var title: String
public var identifier: String?
public var numberOfItem: Int?
public var itemsPerPage: Int?
public var currentPage: Int?
Expand Down
1 change: 1 addition & 0 deletions Tests/OPDSTests/readium_opds1_1_test.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class readium_opds1_1_test: XCTestCase {
}

func testMetadata() {
XCTAssert(feed!.metadata.identifier == "urn:uuid:433a5d6a-0b8c-4933-af65-4ca4f02763eb")
XCTAssert(feed!.metadata.title == "Unpopular Publications")
// TODO: add more tests...
}
Expand Down