Skip to content

Bugfix/incorrect wrap #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 19, 2018
Merged

Bugfix/incorrect wrap #25

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f1dacdf
Add output functionality
iMuzz Jan 10, 2018
ab63945
Merge branch 'master' into feature/outputs
iMuzz Jan 10, 2018
148d519
Make it so that outputs object is optional when passing a callback to…
iMuzz Jan 16, 2018
fad8603
Last argument for `invoke` function now takes an object
iMuzz Jan 17, 2018
ab99b3a
Merge with master
iMuzz Jan 17, 2018
7c7b2d6
Fixed a bug where the output would get incorrectly wrapped
iMuzz Jan 19, 2018
0f796f3
Merge branch 'master' of https://github.com/readmeio/api
iMuzz Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports.config = (apiKey) => {
};

const api = {
run(action, d, outputs, cb) {
run(action, d, opts, cb) {
if (scope.key && scope.key.startsWith('demo')) {
return maybe(cb, new Promise((resolve) => {
console.log('This is a demo API key!'.red);
Expand All @@ -41,8 +41,8 @@ const api = {
let callback = cb;

// Make outputs an optional parameter
if (typeof outputs === 'function') {
callback = outputs;
if (typeof opts === 'function') {
callback = opts;
}

// If no data is passed in, default to {}
Expand Down Expand Up @@ -80,7 +80,7 @@ const api = {
}

return maybe(callback, new Promise((resolve, reject) => {
return invoke(scope.key, scope.service, action, data, { outputs }).then((response) => {
return invoke(scope.key, scope.service, action, data, opts).then((response) => {
return resolve(response);
}).catch((err) => {
return reject(err);
Expand Down