Improve Sync UI/UX #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scarvy
commented
Jan 27, 2025
Collaborator
Author
There was a problem hiding this comment.
If we exclude adding the Tooltip dependency then the PR is actually much smaller +515 -447 😛
Scarvy
commented
Jan 27, 2025
| variant: 'default', | ||
| message: 'Already have permission, writing to Apple Notes.' | ||
| }) | ||
| console.log('MAIN: Already have permission for Apple Notes folder...') |
Collaborator
Author
There was a problem hiding this comment.
Was distracting seeing the toast message, so removed it just for a console log in the backend
Scarvy
commented
Jan 27, 2025
| variant: 'default', | ||
| message: 'Asking for permission for Apple Notes folder.' | ||
| }) | ||
| console.log('MAIN: Asking for permission for Apple Notes folder...') |
Collaborator
Author
There was a problem hiding this comment.
Maybe remove since we do this permission check before on line#119
Collaborator
Author
There was a problem hiding this comment.
and we would prompt the user again for the specific Apple Notes folder access
TristanH
approved these changes
Jan 27, 2025
Member
TristanH
left a comment
TristanH
left a comment
There was a problem hiding this comment.
looks good! tell me when it's live in prod and i'll test it out!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.