build: Disable cargo progress in CI jobs using tty#1419
Closed
ronh-rs wants to merge 1 commit intoI67a788f80925bd2d075d9a0443b44835d90b168dfrom
Closed
build: Disable cargo progress in CI jobs using tty#1419ronh-rs wants to merge 1 commit intoI67a788f80925bd2d075d9a0443b44835d90b168dfrom
ronh-rs wants to merge 1 commit intoI67a788f80925bd2d075d9a0443b44835d90b168dfrom
Conversation
Some buildkite jobs using the docker-compose plugin have tty on because it results in colored output. However, if cargo detects tty, it creates progress bars... which are wholly unnecessary in CI jobs. This update sets CARGO_TERM_PROGRESS_WHEN=never when enabling tty in the docker-compose plugin. Change-Id: I9453179b4294fefd003bf370c5184adf20a4a7a6 Reviewed-on: https://gerrit.readyset.name/c/readyset/+/8625 Tested-by: Buildkite CI Reviewed-by: Michael Zink <michael.z@readyset.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some buildkite jobs using the docker-compose plugin have tty on because
it results in colored output. However, if cargo detects tty, it creates
progress bars... which are wholly unnecessary in CI jobs. This update
sets CARGO_TERM_PROGRESS_WHEN=never when enabling tty in the
docker-compose plugin.