Upgrade all the rubies - use 3.3 by default#106
Merged
djmattyg007 merged 2 commits intorealestate-com-au:mainfrom Apr 23, 2024
Merged
Upgrade all the rubies - use 3.3 by default#106djmattyg007 merged 2 commits intorealestate-com-au:mainfrom
djmattyg007 merged 2 commits intorealestate-com-au:mainfrom
Conversation
djmattyg007
reviewed
Apr 23, 2024
Contributor
djmattyg007
left a comment
djmattyg007
left a comment
There was a problem hiding this comment.
I think this change makes a lot of sense 👍 Should we remove support for Ruby 2.7 while we're here?
Contributor
Author
We could do that. Ruby 3.0 is also EOL as of 3 weeks ago, would you like that removed also? |
Contributor
|
Yep, let's do it. It won't magically remove old versions that do claim support for it. |
|
This also makes #101 redundant, and can be closed |
Contributor
Author
|
Any chance we can get a release? I do believe there is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.