Add scanning materialised views and grants#40
Merged
realkarych merged 2 commits intomasterfrom Jun 14, 2025
Merged
Conversation
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR extends the schema snapshotter to include materialized views and table privilege grants.
- Introduces new
MatViewsandPrivilegesfields in the snapshot model - Implements
scanMatViewsandscanPrivilegesto populate those fields - Updates driver entity definitions to support the new types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/seqwall/staircase.go | Added MatViews/Privileges fields, plus scanMatViews and scanPrivileges methods |
| pkg/driver/entities.go | Defined MatViewDefinition and PrivilegeDefinition, and updated SchemaSnapshot |
Comments suppressed due to low confidence (3)
pkg/seqwall/staircase.go:728
- There are no tests covering the new
scanMatViewsandscanPrivilegesfunctions. Please add unit or integration tests to verify that materialized views and privileges are being correctly retrieved and stored.
func (s *StaircaseWorker) scanMatViews(snapshot *driver.SchemaSnapshot) error {
pkg/driver/entities.go:95
- [nitpick] Add a doc comment above
MatViewDefinition(and similarly forPrivilegeDefinition) to explain what each type represents and how its fields are used.
type MatViewDefinition struct {
pkg/seqwall/staircase.go:202
- [nitpick] Consider initializing
Privilegesto an empty slice in theSchemaSnapshotliteral (e.g.Privileges: []driver.PrivilegeDefinition{},) so JSON marshalling always produces[]instead ofnullwhen no grants are found.
snap := &driver.SchemaSnapshot{
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.