Exclude weak_delegate rule from autocorrection#4153
Merged
SimplyDanny merged 3 commits intorealm:mainfrom Sep 6, 2022
Merged
Conversation
Generated by 🚫 Danger |
SimplyDanny
force-pushed
the
exclude-weak_delegate-rule-from-autocorrection
branch
from
0859bcd to
d2d3630
Compare
SimplyDanny
force-pushed
the
exclude-weak_delegate-rule-from-autocorrection
branch
from
d2d3630 to
ec61a2a
Compare
Collaborator
Author
Collaborator
|
I wonder if this is because I need to flip a flag in Azure Pipelines to allow external repos to access these credentials 🤔 Looking into it. |
Collaborator
|
Just checked this, let's see if that works.
|
Collaborator
|
I give up. I may need to disable the remote cache on Azure Pipelines completely. |
Collaborator
|
ok I think it's working now. |
Collaborator
|
It appears to only work on new commits. |
jpsim
approved these changes
Sep 6, 2022
Collaborator
jpsim
left a comment
jpsim
left a comment
There was a problem hiding this comment.
Not great, but the rule is flawed to start with.
Collaborator
Author
Indeed. Thank you for looking into the build issues! |
SimplyDanny
deleted the
exclude-weak_delegate-rule-from-autocorrection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3577.