Skip to content

Track type member declarations optionally#6596

Merged
SimplyDanny merged 1 commit intomainfrom
optional-members
Apr 15, 2026
Merged

Track type member declarations optionally#6596
SimplyDanny merged 1 commit intomainfrom
optional-members

Conversation

@SimplyDanny
Copy link
Copy Markdown
Collaborator

No description provided.

@SwiftLintBot
Copy link
Copy Markdown

SwiftLintBot commented Apr 14, 2026

187 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/TabbedPageViewController.swift:273:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/TabExtensions.swift:69:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShared/Extensions/StringExtensions.swift:27:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShields/Domain+Extensions.swift:20:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/Common/XCUIElementExtension.swift:23:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/Common/XCUIElementExtension.swift:197:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/Common/XCUIApplicationExtension.swift:291:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/Common/XCUIApplicationExtension.swift:301:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/Common/XCUIApplicationExtension.swift:315:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/Common/XCUIApplicationExtension.swift:320:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/SwiftUIExtensions/Sources/SwiftUIExtensions/SlidingPickerView.swift:189:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Sources/DataBrokerProtection-macOS/Utils/DataBrokerProtectionSettings+macOS.swift:34:23: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/LogExporter/MainViewController+LogExporter.swift:61:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Tab/TabExtensions/HistoryTabExtension.swift:334:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NavigationBar/View/NavigationButtonMenuDelegate.swift:50:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NavigationBar/View/AddressBarTextEditor.swift:541:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/InternalUserDecider/InternalUserDeciderStore.swift:74:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/Extensions/WKWebViewExtension.swift:112:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/Extensions/WKWebViewExtension.swift:154:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/Extensions/NSPasteboardExtension.swift:40:60: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/Extensions/URLExtension.swift:804:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/Extensions/NSPopoverExtension.swift:76:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/Common/View/AppKit/NSSavePanelExtension.swift:69:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/SystemExtensionAndNotificationTargets/Bundle+NetworkProtectionExtensions.swift:33:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/SystemExtensionAndNotificationTargets/Bundle+NetworkProtectionExtensions.swift:40:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/SecureVault/CreditCardValidation.swift:172:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Networking/v2/Extensions/HTTPURLResponse+Etag.swift:27:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Crashes/Mach-O/section+helpers.swift:33:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Navigation/Extensions/WKWebpagePreferencesExtension.swift:70:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Navigation/Extensions/WKNavigationActionExtension.swift:191:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/SecureStorage/SecureStorageError.swift:94:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Common/Extensions/URLExtension.swift:286:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/SpecialErrorPages/SSLErrorType.swift:68:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/PixelKit/PixelKitEvent.swift:44:20: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/PixelKit/PixelKitEvent.swift:51:24: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/UIColorExtension.swift:34:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/UIColorExtension.swift:40:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/UIColorExtension.swift:46:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/UIColorExtension.swift:52:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/SearchBarExtension.swift:34:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/BookmarkObjects.swift:45:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/FavoritesListInteractingAdapter.swift:101:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/WebExtensions/Sources/WebExtensions/WKWebExtensionContext+Extension.swift:74:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/VPN/Sources/VPN/Settings/Extensions/UserDefaults+dnsSettings.swift:96:21: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/AIChat/Sources/AIChat/Shared/URL+Extension.swift:51:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/AIChat/Sources/AIChat/Shared/URL+Extension.swift:105:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:317:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:322:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:335:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:382:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:397:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:420:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:431:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:444:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:458:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:496:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:524:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:527:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:530:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:593:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/Pixels/DataBrokerProtectionSharedPixels.swift:599:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /focus-ios/Blockzilla/Extensions/URLExtensions.swift:354:57: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /focus-ios/Blockzilla/AppDelegate.swift:336:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/Storage/Rust/RustLogins.swift:41:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/Storage/Rust/RustLogins.swift:123:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/OnboardingKit/Models/OnboardingCardInfoModelProtocol.swift:47:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Shared/AppInfo.swift:10:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Common/Extensions/URLExtension.swift:12:57: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Common/Extensions/URLExtension.swift:97:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Common/Extensions/URLExtension.swift:99:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Common/Extensions/URLExtension.swift:208:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/Common/Extensions/UIColorExtensions.swift:29:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in NetNewsWire: /Shared/Article Rendering/WebViewConfiguration.swift:85:7: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in NetNewsWire: /Shared/Article Rendering/WebViewConfiguration.swift:96:7: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in NetNewsWire: /Shared/Article Rendering/WebViewConfiguration.swift:102:7: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in PocketCasts: /podcasts/Sharing/SharingModal.swift:190:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in PocketCasts: /podcasts/Sharing/SharingModal.swift:304:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in PocketCasts: /podcasts/Enumerations.swift:12:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in PocketCasts: /podcasts/Enumerations.swift:140:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in PocketCasts: /podcasts/ChaptersViewController+Table.swift:21:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in PocketCasts: /podcasts/DeveloperMenu.swift:441:56: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Quick: /Sources/Quick/String+C99ExtendedIdentifier.swift:6:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/UnicodeScalarProperties.swift:852:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/UnicodeScalarProperties.swift:1254:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/CommandLine.swift:53:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Array.swift:1754:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Array.swift:1760:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Array.swift:1879:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyValuePairs.swift:137:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ArraySlice.swift:1233:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ArrayBuffer.swift:658:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Span/OutputSpan.swift:366:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Span/OutputSpan.swift:381:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Span/MutableRawSpan.swift:205:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Span/MutableRawSpan.swift:216:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/CollectionOfOne.swift:171:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/CollectionOfOne.swift:183:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Dictionary.swift:1426:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/StringCharacterView.swift:276:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Bitset.swift:136:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/InlineArray.swift:593:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/InlineArray.swift:596:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/InlineArray.swift:608:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/InlineArray.swift:611:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/_InlineArray.swift:470:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/_InlineArray.swift:480:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ContiguousArray.swift:1298:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Cxx/CxxVector.swift:60:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Cxx/std/String.swift:548:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Cxx/std/String.swift:579:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Cxx/std/String.swift:594:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Cxx/std/String.swift:609:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/RuntimeModule/ImageMap+Darwin.swift:46:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/RuntimeModule/ImageMap+Darwin.swift:48:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/RuntimeModule/ImageMap+Darwin.swift:50:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/RuntimeModule/ImageMap+Darwin.swift:52:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Swift: /stdlib/public/RuntimeModule/ImageMap+Darwin.swift:54:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in VLC: /Sources/Helpers/KeychainCoordinator.swift:124:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios-utilities/Source/Public/UIColor/UIColor+Hex.swift:37:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/Components/MediaAsset.swift:104:20: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/GroupDetails/ConversationActions/ConversationAction.swift:65:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/GroupDetails/ConversationActions/ConversationAction.swift:81:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/GroupDetails/ConversationActions/ConversationAction.swift:100:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/AddContacts/AddParticipantsViewController.swift:39:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+Forward.swift:41:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/Utility/NSAttributedString+MessageFormatting.swift:53:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/Utility/NSAttributedString+MessageFormatting.swift:63:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/Utility/NSAttributedString+MessageFormatting.swift:71:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/Utility/NSAttributedString+MessageFormatting.swift:87:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/Helpers/syncengine/ZMLocationMessageData+Coordinates.swift:60:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ This PR introduced a violation in Wire: /wire-ios/Wire-iOS/Sources/Helpers/syncengine/Message+DateFormatter.swift:25:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ Danger found 187 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 133.
707 Messages
📖 Building this branch resulted in a binary size of 27544.71 KiB vs 27560.34 KiB when built on main (-1% smaller).
📖 Linting Aerial with this PR took 0.81 s vs 0.82 s on main (1% faster).
📖 Linting Alamofire with this PR took 1.06 s vs 1.06 s on main (0% slower).
📖 Linting Brave with this PR took 7.37 s vs 7.33 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 28.43 s vs 28.45 s on main (0% faster).
📖 Linting Firefox with this PR took 12.27 s vs 12.28 s on main (0% faster).
📖 Linting Kickstarter with this PR took 8.48 s vs 8.53 s on main (0% faster).
📖 Linting Moya with this PR took 0.44 s vs 0.48 s on main (8% faster).
📖 Linting NetNewsWire with this PR took 2.66 s vs 2.65 s on main (0% slower).
📖 Linting Nimble with this PR took 0.69 s vs 0.7 s on main (1% faster).
📖 Linting PocketCasts with this PR took 7.85 s vs 8.0 s on main (1% faster).
📖 Linting Quick with this PR took 0.47 s vs 0.46 s on main (2% slower).
📖 Linting Realm with this PR took 3.05 s vs 3.04 s on main (0% slower).
📖 Linting Sourcery with this PR took 1.88 s vs 1.89 s on main (0% faster).
📖 Linting Swift with this PR took 4.75 s vs 4.76 s on main (0% faster).
📖 Linting SwiftLintPerformanceTests with this PR took 0.33 s vs 0.34 s on main (2% faster).
📖 Linting VLC with this PR took 1.26 s vs 1.25 s on main (0% slower).
📖 Linting Wire with this PR took 19.13 s vs 19.07 s on main (0% slower).
📖 Linting WordPress with this PR took 12.92 s vs 12.95 s on main (0% faster).
📖 This PR fixed a violation in Aerial: /Resources/MainUI/VideosViewController.swift:203:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:177:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:233:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:357:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Time/Solar.swift:200:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/PrefPanel/CheckCellView.swift:42:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoder.swift:79:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoder.swift:163:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Alamofire: /Example/Source/DetailViewController.swift:94:20: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Alamofire: /Tests/RequestTests.swift:1497:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Alamofire: /Tests/RequestTests.swift:1503:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Alamofire: /Tests/SessionTests.swift:49:21: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Alamofire: /Tests/SessionTests.swift:76:21: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Alamofire: /Tests/SessionTests.swift:145:25: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/WalletStore.swift:162:18: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/SwapTokenStore.swift:941:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/SwapTokenStore.swift:1176:14: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/AssetDetailStore.swift:440:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/SendTokenStore.swift:304:15: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/SendTokenStore.swift:380:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/SendTokenStore.swift:658:15: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletPromptView.swift:44:14: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Panels/SignTransaction/SignTransactionView.swift:187:20: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Favicon/FaviconFetcher.swift:99:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/PlaylistScriptHandler.swift:199:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/PlaylistScriptHandler.swift:204:14: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/BraveTranslate/BraveTranslateTabHelper.swift:78:18: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/BraveTranslate/BraveTranslateTabHelper.swift:113:34: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/BraveTranslate/BraveTranslateTabHelper.swift:113:54: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/BraveTranslate/BraveTranslateTabHelper.swift:233:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/BraveTranslate/BraveTranslateTabHelper.swift:432:14: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Rewards/BraveRewards.swift:68:34: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Rewards/BraveRewards.swift:153:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/SwipeAnimator.swift:41:15: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/UserScriptManager.swift:291:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Tabs/TabGrid/TabGridContainerView.swift:476:29: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Tabs/TabGrid/TabGridItemView.swift:34:12: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/FrequencyQuery.swift:57:36: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/FrequencyQuery.swift:80:36: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Playlist/Utilities/PlaylistThumbnailUtility.swift:232:12: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/DownloadToast.swift:112:12: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/DownloadToast.swift:123:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Tab+TabContentScript.swift:76:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/TemporaryDocument.swift:68:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController.swift:1473:21: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Search/BraveSearchTabHelper.swift:170:35: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Authenticator.swift:41:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BackForwardListViewController.swift:134:15: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BackForwardListViewController.swift:172:15: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Toolbars/BottomToolbar/Menu/Bookmarks/BookmarkDetailsView.swift:161:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Toolbars/UrlBar/TabLocationView.swift:730:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Helpers/TranslateTabHelper.swift:51:27: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Helpers/TranslateTabHelper.swift:61:27: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/TabManager.swift:190:15: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/TabManager.swift:629:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/TabManager.swift:980:12: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/TabManager.swift:1202:15: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Sync/BraveCore/Bookmarks/BookmarkFetchers.swift:69:12: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Widgets/AutocompleteTextField.swift:115:15: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Widgets/TwoLineCell.swift:269:15: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Widgets/TwoLineCell.swift:353:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Networking/NetworkSessionMock.swift:93:14: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ContentBlocker/ContentBlockerManager.swift:395:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Growth/DAU.swift:288:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Growth/DAU.swift:322:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/CertificateUtilities/BraveCertificateUtils.swift:62:11: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/Statistics/FeatureDiscovery.swift:101:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/Statistics/UsageSegmentation.swift:101:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/SecureVault/SecureVaultModels.swift:137:20: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/ReferrerTrimming/ReferrerTrimming.swift:151:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/ContentBlocking/UserScripts/TrackerResolver.swift:48:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/PrivacyConfig/PopupBlockingConfiguration.swift:112:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/PrivacyConfig/PopupBlockingConfiguration.swift:113:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Networking/v1/APIRequest.swift:68:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Networking/Auth/OAuthRequest.swift:146:20: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Networking/v2/APIService.swift:57:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Navigation/NavigationAction.swift:79:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Navigation/NavigationAction.swift:131:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Navigation/DistributedNavigationDelegate.swift:363:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/SecureStorage/SecureVaultFactory.swift:67:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Subscription/API/SubscriptionEndpointService.swift:187:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/PrivacyDashboard/BrokenSiteReporting/BrokenSiteReporter.swift:64:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/DDGSync/internal/RemoteAPIRequestCreatingExtensions.swift:28:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/DDGSync/internal/RemoteAPIRequestCreatingExtensions.swift:46:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /macOS/IntegrationTests/Fire/FireCoordinatorIntegrationTests.swift:3131:25: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/HTTPServerAdditions.swift:216:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:488:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/NavigationTestHelpers.swift:256:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/BrowserServicesKitTests/ContentBlocker/ContentBlockerRulesManagerTests.swift:1213:17: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/Common/UITests.swift:236:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/Common/UITests.swift:247:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/TestUtilities/Sources/SharedTestUtilities/Encryption/EncryptionKeyStoreMock.swift:47:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/TestUtilities/Sources/SharedTestUtilities/Common/FindInView.swift:30:9: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:1783:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Suggestions/Model/SuggestionContainerTests.swift:467:25: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:45:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:59:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:73:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:87:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:101:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:115:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:139:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:156:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:185:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:214:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:245:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:277:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:302:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/LocalBrokerJSONServiceTests.swift:331:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/LocalPackages/DataBrokerProtection-iOS/Sources/DataBrokerProtection-iOS/Debug/DatabaseBrowser/DebugDatabaseBrowserViewModel.swift:50:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/Core/BookmarksCachingSearch.swift:193:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/Core/PersistentPixel.swift:98:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/Core/PersistentPixel.swift:143:13: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/SpeechRecognizer.swift:109:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/SyncSettingsViewController.swift:424:19: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/SwiftUICollectionViewCell.swift:29:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingFlow/LinearOnboarding/Rebranding/Components/AddToDock/RebrandedAddToDockPromoView.swift:49:28: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingFlow/LinearOnboarding/Rebranding/Components/AddToDock/RebrandedAddToDockTutorialView.swift:99:28: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AutofillBreakageReportTableViewCell.swift:28:16: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppServices/CrashCollectionService.swift:48:21: Warning: Do not shadow variables declared in outer scopes (variable_shadowing)
⚠️ Danger found 707 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 139.

Here's an example of your CHANGELOG entry:

* Track type member declarations optionally.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit ceef663 into main Apr 15, 2026
29 of 30 checks passed
@SimplyDanny SimplyDanny deleted the optional-members branch April 15, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants