fix: unused_declaration skip UIKit/WebKit delegate methods#6707
Closed
leno23 wants to merge 3 commits into
Closed
Conversation
Skip classes inheriting UIKit/WebKit/NS delegate protocols and subclass protocol witness methods referenced via key.related_decls. Fixes realm#4706
Linux CI cannot compile UIKit/WebKit imports in rule examples.
macOS hosts without UIKit (non-Catalyst) cannot compile UIKit imports in analyzer rule examples.
Contributor
|
Hi @leno23, thanks for opening this PR. I'm automatically closing it because there are earlier PRs from your account with open review discussions that haven't received a reply yet. There is nothing wrong with using tools to help — but open source thrives on collaboration and engagement. Once you've addressed the open threads in your previous PRs, feel free to open a new one. |
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4706\n\n## Test plan\n- [x] Rule generated tests
Made with Cursor