Save LogCat file in case of test failure#3058
Merged
Conversation
This reverts commit a841361.
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move from #3049
If unit tests crashes with native exceptions we currently have no way of knowing why.
With this PR we now save the LogCat file in case there is a test failure. For green builds nothing is saved.
A local test on my phone indicates that a full logcat file is ~8MB in size and 400Kb when zipped.
The CI log seems to be much smaller (~4Mb compressed to 130k)
An example is here: https://ci.realm.io/job/android-pr-jenkinsfile/630/
We need to enable logging before starting tests as Android only have a 256Kb buffer for log entries and rotates between multiple files. This means that dumping the log afterwards are missing a lot of entries.
@realm/java
@emanuelez