Update compileSdkVersion and build tools to 24#3062
Conversation
zaki50
force-pushed
the
my/update_to_api_24
branch
10 times, most recently
from
71f9ffe to
b43a420
Compare
zaki50
force-pushed
the
my/update_to_api_24
branch
from
b43a420 to
e26d62f
Compare
|
@realm/java Should we keep |
| @@ -1,5 +1,5 @@ | |||
| project.ext.sdkVersion = 23 | |||
| project.ext.buildTools = '23.0.0' | |||
| project.ext.sdkVersion = 24 | |||
There was a problem hiding this comment.
Because most devices cannot support SDK version 24 yet, I don't know that using SDK version 24 is a good idea.
There was a problem hiding this comment.
The SDK version should not have any effect on what is actual running on the device. This is just used to compile everything with.
|
@zaki50 Do you know of any problems between 23.0.0 and 24.0.0 that might effect us? Otherwise I would say it should be safe to upgrade. |
|
Yes, I think we should keep |
|
@cmelchior I don't think that effects for us. But it has some effect for the users. I'll keep |
|
Ah yes, good point 👍 |
| RUN cd /opt && rm -f android-sdk.tgz | ||
|
|
||
| # Grab what's needed in the SDK | ||
| RUN echo y | android update sdk --no-ui --all --filter tools > /dev/null |
There was a problem hiding this comment.
can you explain why this different pattern to install tools? Maybe a comment will help not changing it to be like the others by mistake.
There was a problem hiding this comment.
Right.
The story is a bit weird.
Running RUN echo y | android update sdk --no-ui --all --filter tools produces following output.
...
Installing Archives:
Preparing to install archives
Skipping 'Android SDK Tools, revision 25.1.7'; it depends on 'Android SDK Platform-tools, revision 24' which was not installed.
Done. Nothing was installed.
This says that install was skipped and nothing was installed. But, if I remove this line, the lint check does not pass.
@emanuelez Do you know why this happens?
There was a problem hiding this comment.
They made some changes to the command line tool in the last versions, it might not even work anymore. I cannot remember the details though.
|
LGTM |
|
review this please @realm/java |
|
LGTM 👍 |
|
👍 |
5 participants
refs #3051