Unit tests for PrimaryKey field type change#3076
Merged
Conversation
CHANGELOG.md
Outdated
|
|
||
| ### Enhancements | ||
|
|
||
| * Unit tests for checking proper migration of primary key field type change from `String` to `Integer`/`int` (#3068). |
Contributor
There was a problem hiding this comment.
We normally don't put internal changes in the changelog
Contributor
Author
|
@realm/java please review. |
|
|
||
| public static String FIELD_PRIMARY = "fieldIntPrimary"; | ||
|
|
||
| private Byte fieldFirst; |
Contributor
There was a problem hiding this comment.
The test class can be much shorter by removing the getters/setters and just using the public field.
Contributor
|
👍 with a minor comment |
|
|
||
| private void createObjectsWithOldPrimaryKey(final String className, final boolean insertNullValue) { | ||
| DynamicRealm realm = DynamicRealm.getInstance(configFactory.createConfigurationBuilder().build()); | ||
| realm.executeTransaction(new DynamicRealm.Transaction() { |
Contributor
|
I don't think we need to update Please merge latest |
Contributor
Author
|
retest this please |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests for checking proper migration of PrimaryKey field type change from String to Integer/int. These cases were surfaced in issue #3068.