Allow empty collection to insert/insertOrUpdate(Collection)#3106
Merged
Allow empty collection to insert/insertOrUpdate(Collection)#3106
Conversation
Contributor
Author
|
review this please @realm/java |
| } | ||
| }); | ||
| assertEquals(0, realm.where(Cat.class).count()); | ||
| } finally { |
Contributor
There was a problem hiding this comment.
This is being called in tearDown() as well?
Contributor
There was a problem hiding this comment.
No, this Realm is opened in line 410.
Contributor
Author
|
review this please @realm/java |
Contributor
|
👍 |
Contributor
Author
|
retest this please |
| * | ||
| * @param realm reference to the {@link Realm} where the objects will be inserted. | ||
| * @param objects Collection of {@link RealmObject} to insert or update. | ||
| * @param objects Collection of {@link RealmObject} to insert or update. This must not be empty. |
Contributor
There was a problem hiding this comment.
I think that "must not" is a bit too strong. If objects is empty, it is a no-op (we don't throw an exception). Maybe "should not" is better.
Contributor
Author
There was a problem hiding this comment.
no. If the objects is empty, some mediators actually throws an exception.
see #3106 (diff)
Contributor
|
👍 with a minor comment on documentation. |
Contributor
Author
|
retest this please |
Contributor
|
👍 |
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3103