Skip to content

improve generated javadoc#3110

Merged
cmelchior merged 1 commit intorealm:masterfrom
larsgrefer:improveJavadoc
Jul 5, 2016
Merged

improve generated javadoc#3110
cmelchior merged 1 commit intorealm:masterfrom
larsgrefer:improveJavadoc

Conversation

@larsgrefer
Copy link
Copy Markdown
Contributor

link against JavaSE, Android, and RxJava

see also: realm/realm-android-adapters#55

link against JavaSE, Android, and RxJava
@stk1m1 stk1m1 added the S:Review label Jul 3, 2016
@stk1m1
Copy link
Copy Markdown
Contributor

stk1m1 commented Jul 3, 2016

@LarsFrid

Thanks for your contribution. It would be easier if you could upload generated javadocs somewhere to compare. Javadoc generation is a part of release cycle and the end results affects everyone so we'd like to take some caution. Great work btw 💯

@beeender
Copy link
Copy Markdown
Contributor

beeender commented Jul 5, 2016

👍 👏 🎉

@cmelchior
Copy link
Copy Markdown
Contributor

Very nice 👍 💯

@cmelchior cmelchior merged commit b347fdd into realm:master Jul 5, 2016
@cmelchior cmelchior removed the S:Review label Jul 5, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants