Primitive List feature(Part6: OsList)#5208
Merged
zaki50 merged 9 commits intofeature/primitive_listfrom Sep 11, 2017
Merged
Conversation
zaki50
force-pushed
the
my/primitive_list_6_OsList
branch
from
0519058 to
6ec1b48
Compare
cmelchior
approved these changes
Sep 5, 2017
| Long val = null; | ||
| if (reader.peek() != JsonToken.NULL) { | ||
| val = reader.nextLong() | ||
| val = reader.nextLong(); |
Contributor
There was a problem hiding this comment.
How did this compile before? 🤔
Contributor
Author
There was a problem hiding this comment.
I guess Google's compile-testing library does not see semi-colons when comparing generated code.
Contributor
Author
|
@cmelchior I've asked @beeender to implement empty methods in this PR. |
Contributor
Author
|
Implementation of Could you review this? @realm/java |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.