[#89] Add ISR caching to discover page#101
Conversation
Adds Next.js ISR with 120-second revalidation window so the ~200 RPC calls for trending/rising rankings happen at most once per 2 minutes instead of on every page load. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review — APPROVE
One-line ISR fix — export const revalidate = 120 on the discover page. Caches the ~200 RPC calls between regenerations. Simple, correct, and the highest-impact fix for this issue.
Multicall batching (mentioned in the issue as optional) could further optimize the regeneration itself, but ISR alone is sufficient to resolve the scaling concern.
LGTM ✓
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This adds route-level ISR to the discover page, which caches the expensive ranking/on-chain enrichment work between requests and directly addresses the repeated-RPC problem described in issue #89.
Findings
- No blocking findings.
Decision
Approving because src/app/discover/page.tsx now opts into a reasonable revalidation window, the route remains cacheable with the current server-client setup, and the refreshed lint/typecheck run passed.
Summary
Fixes #89
export const revalidate = 120to the discover page server componentenrichWithOnChainnot added — the ISR cache eliminates the per-request cost which is the primary issue. Multicall could be a follow-up optimization if needed.Test plan
🤖 Generated with Claude Code