Add cartoon reader rendering with webtoon layout#1219
Conversation
StoryContent now accepts a contentType prop. When "cartoon", renders markdown images as a vertical webtoon layout: full-width responsive images with minimal gaps, centered in a max-w-2xl container. Scene labels render as centered bold text above panels. Fiction/undefined content type uses the existing prose styling path. Both story detail and individual plot pages pass content_type through. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
left a comment
realproject7
left a comment
There was a problem hiding this comment.
RE2 Review: ✅ Approve
Minimal, focused change. Well done keeping this scoped.
Highlights:
- Clean branching in
StoryContent— cartoon path returns early, fiction path untouched - Custom ReactMarkdown components map cartoon markdown structure (images, separators, bold labels) to proper webtoon layout
loading="lazy"on images — good for long scrolling comicsmax-w-2xl+mx-autocenters the reader nicely on desktop while staying responsive- Both story detail and plot detail pages correctly pass
content_typethrough
No concerns. CI pending at review time.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The normal story detail and plot pages now pass content_type into StoryContent, but the reading-mode overlay still renders every chapter through the default fiction path. That leaves a user-facing reader path for cartoon stories without the required webtoon layout.
Findings
- [medium] Reading mode does not receive or pass
contentType, so cartoon plots opened in the reader overlay render with prose styling instead of the vertical webtoon layout.- File:
src/components/ReadingMode.tsx:262 - Suggestion: Thread
contentTypefromStoryPage/ plot detail intoReadingModeWrapper, then intoReadingMode, and pass it to both incoming and outgoingStoryContentcalls. Keep undefined/fiction using the current prose path.
- File:
Decision
Requesting changes because #1214 requires branching reader rendering via storyline.content_type, and reading mode is part of the reader surface. CI was still pending at review time.
Passes content_type from storyline through ReadingModeWrapper and ReadingMode to StoryContent, so cartoon stories use the webtoon layout in the reading overlay as well as the main view. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The requested reading-mode fix is in place. contentType is now threaded from story/plot pages through ReadingModeWrapper and ReadingMode into both StoryContent render sites, so cartoon content uses the webtoon layout in the overlay as well as the standard reader pages.
Findings
- None blocking.
Decision
Approved. The prior RE1 finding is resolved, and both lint-and-typecheck and e2e are green on the updated commit.
2 participants
Summary
StoryContentnow accepts optionalcontentTypepropcontentType === "cartoon": renders as vertical webtoon layout with full-width responsive images, minimal gaps, and centered scene labelscontent_typethroughCloses #1214
Test plan
🤖 Generated with Claude Code