Show USD as primary Creator Earnings on profile page#1220
Merged
Conversation
When PLOT USD price is available, shows USD value as the primary display with PLOT amount as secondary text below. Falls back to PLOT-only when USD price is unavailable. Matches the story detail page pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
commented
May 16, 2026
Owner
Author
realproject7
left a comment
realproject7
left a comment
There was a problem hiding this comment.
RE2 Review: ✅ Approve
Minimal, correct change. Logic is straightforward:
/bin/zshwhen no earnings- USD primary (via
formatUsdValue) + PLOT secondary when price available - PLOT-only fallback when USD price unavailable
Matches the story detail pattern as intended. No concerns.
project7-interns
approved these changes
May 16, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The profile Creator Earnings display now matches the intended story-detail pattern: USD is primary when a PLOT/USD price is available, the PLOT amount is shown as secondary, and it falls back to PLOT-only when USD pricing is unavailable.
Findings
- None blocking.
Decision
Approved. The change is minimal and matches #1208 acceptance criteria. lint-and-typecheck is green; e2e was still pending at approval time and should be verified before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usePlotUsdPrice()is availableCreatorEarningsBoxpatternCloses #1208
Test plan
🤖 Generated with Claude Code