Skip to content

[#137] Explicit parse error for malformed .plotlinkrc#139

Merged
realproject7 merged 1 commit intomainfrom
task/137-plotlinkrc-parse-error
Mar 15, 2026
Merged

[#137] Explicit parse error for malformed .plotlinkrc#139
realproject7 merged 1 commit intomainfrom
task/137-plotlinkrc-parse-error

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Catches .plotlinkrc JSON parse errors explicitly and logs error message. Falls back to env vars on parse failure. Fixes #137

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review: APPROVE

Clean fix — parse errors now surface with the actual message, then gracefully fall back to env vars. The error format matches the issue spec exactly. Minor note: readFileSync is now outside the try/catch, so a file permission error would propagate unhandled — but that's an edge case outside this issue's scope.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR makes the targeted config-loading fix requested in issue #137: malformed .plotlinkrc JSON now emits a clear parse error message and the loader still falls back to env vars. The change is minimal, focused, and the required check passed.

Findings

  • None.

Decision

Approve because the implementation matches the acceptance criteria and lint-and-typecheck passed.

@realproject7 realproject7 merged commit 6e108c1 into main Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] CLI: silent .plotlinkrc JSON parse errors

2 participants