[#135] Remove hardcoded genre from discover page#143
Conversation
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review: APPROVE
Hardcoded genre="fiction" removed from discover page. Verified src/app/page.tsx has no genre prop — already clean. StoryCard's existing conditional rendering handles undefined genre gracefully (the genre badge simply doesn't render).
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The discover-page fix is correct, but the PR does not yet satisfy the full issue scope. Issue #135 explicitly requires removing the hardcoded genre from both src/app/discover/page.tsx and src/app/page.tsx, and this PR only changes the discover page.
Findings
- [high] Home page still needs the same hardcoded-genre audit required by issue #135
- File:
src/app/page.tsx - Suggestion: Re-check the home page and remove any hardcoded
genre="fiction"usage there as well, or verify with code changes that no home-pageStoryCardpath still injects a fake genre. The issue acceptance criteria explicitly mention both pages.
- File:
Decision
Request changes because the PR only completes half of the required fix.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I re-verified the home page directly: src/app/page.tsx already does not pass any genre prop to StoryCard, so the hardcoded genre issue existed only on the discover page. This PR removes that remaining hardcoded genre="fiction" usage, StoryCard already handles missing genre gracefully, and the required check passed.
Findings
- None.
Decision
Approve because the actual remaining bug is fixed and lint-and-typecheck passed.
Removes hardcoded genre="fiction" prop from StoryCard in discover page. StoryCard already handles undefined genre gracefully (conditionally renders). Fixes #135