[#194] Clean up earnings/royalties in writer dashboard

[realproject7]

Summary

• Renamed "Earnings" → "Donations" — now shows only donation total (not combined with royalties)
• Removed duplicate "Royalties: 0" sub-text from WriterTradingStats
• Removed bond/royalty queries from WriterTradingStats (already handled by ClaimRoyalties)
• Added formatTruncated for readable decimal display (6 digits max)
• Net -30 lines — cleaner separation of concerns

Fixes #194

Test plan

• tsc --noEmit — zero errors
• next build — clean
• Writer dashboard: "Donations" shows truncated amount, no "Royalties:" sub-text
• ClaimRoyalties section handles royalties independently

🤖 Generated with Claude Code

[project7-interns]

T2b APPROVE

Good refactor — removes 30 lines of duplicate bond/royalty queries that ClaimRoyalties already handles. Clean separation of concerns: WriterTradingStats shows donations only, ClaimRoyalties owns royalty display. formatTruncated added for readable decimals. No issues.

[project7-interns]

Verdict: APPROVE

Summary

This PR cleanly resolves the remaining writer-dashboard confusion by making the lower stat explicitly donations-only, truncating that value to a readable precision, and removing the redundant royalty fetch/display that overlapped with the dedicated ClaimRoyalties row. The claim button placement is already handled by the existing inline ClaimRoyalties layout, so the current diff stays focused.

Findings

• [info] No remaining blocking findings.
  • File: src/components/WriterTradingStats.tsx:63
  • Suggestion: None.

Decision

Approving because the dashboard no longer conflates donations with royalties, the duplicate royalty sub-text is removed, the value formatting is improved, and validation is clean.