[#198] Combine Home + Discovery into single page with grid layout#205
[#198] Combine Home + Discovery into single page with grid layout#205realproject7 merged 2 commits intomainfrom
Conversation
- Home page now has tabs (new/trending/rising/completed), writer filter (all/human/agent), and responsive 3-column grid - /discover redirects to / (preserves old URLs) - Removed "discover" from NavBar - TabNav and WriterFilter accept basePath prop (no longer hardcoded) - Wider max-w-5xl layout for grid, max-w-2xl → max-w-5xl Fixes #198 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Well-executed page merge:
- Home page — Now has full tabs, writer filter, and responsive 3-col grid (
grid-cols-1 sm:grid-cols-2 lg:grid-cols-3).queryTabmoved from discover. Layout widened tomax-w-5xl. - Discover — Replaced with
redirect("/")to preserve old URLs. Clean. - TabNav/WriterFilter —
basePathprop added (default "/"), no longer hardcoded to/discover. - NavBar — "discover" link removed.
Net -85 lines. No issues.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
Combining Home and Discovery is directionally correct, but the new /discover redirect currently drops the existing query-string state. That creates a behavioral regression for shared or bookmarked discovery links that previously encoded the selected tab and writer filter.
Findings
- [high]
/discoverredirect loses tab/filter query params instead of preserving them on/.- File:
src/app/discover/page.tsx:4 - Suggestion: Read
searchParamsin the redirect route and forward them to/so URLs like/discover?tab=rising&writer=agentbecome/?tab=rising&writer=agentrather than plain/.
- File:
Decision
Requesting changes because the redirect behavior regresses existing filtered discovery URLs during the route migration.
Old URLs like /discover?tab=rising&writer=agent now correctly map to /?tab=rising&writer=agent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up commit fixes the migration regression I flagged by preserving discovery query params when redirecting old /discover URLs to /. That keeps bookmarked and shared filtered links working after the Home/Discovery merge.
Findings
- [info] Previous blocking finding resolved.
- File:
src/app/discover/page.tsx:10 - Suggestion: None.
- File:
Decision
Approving because /discover?tab=...&writer=... now redirects to /?tab=...&writer=..., which clears the route-migration regression, and GitHub validation is passing.
Summary
/discoverredirects to/(preserves old URLs)TabNavandWriterFilteracceptbasePathprop (no longer hardcoded to/discover)max-w-5xllayout for grid displayFixes #198
Test plan
tsc --noEmit— zero errorsnext build— clean/discoverredirects to/🤖 Generated with Claude Code