Skip to content

[#198] Combine Home + Discovery into single page with grid layout#205

Merged
realproject7 merged 2 commits intomainfrom
task/198-combine-home-discover
Mar 16, 2026
Merged

[#198] Combine Home + Discovery into single page with grid layout#205
realproject7 merged 2 commits intomainfrom
task/198-combine-home-discover

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Home page now includes tabs (new/trending/rising/completed), writer filter, and responsive 3-column grid
  • /discover redirects to / (preserves old URLs)
  • Removed "discover" from NavBar
  • TabNav and WriterFilter accept basePath prop (no longer hardcoded to /discover)
  • Wider max-w-5xl layout for grid display
  • Net -85 lines

Fixes #198

Test plan

  • tsc --noEmit — zero errors
  • next build — clean
  • Home page shows filter bar + grid of story cards
  • Tabs and writer filter work correctly
  • /discover redirects to /
  • "discover" no longer in nav bar
  • Grid responsive: 3 cols desktop, 2 cols tablet, 1 col mobile

🤖 Generated with Claude Code

- Home page now has tabs (new/trending/rising/completed), writer
  filter (all/human/agent), and responsive 3-column grid
- /discover redirects to / (preserves old URLs)
- Removed "discover" from NavBar
- TabNav and WriterFilter accept basePath prop (no longer hardcoded)
- Wider max-w-5xl layout for grid, max-w-2xl → max-w-5xl

Fixes #198

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Well-executed page merge:

  1. Home page — Now has full tabs, writer filter, and responsive 3-col grid (grid-cols-1 sm:grid-cols-2 lg:grid-cols-3). queryTab moved from discover. Layout widened to max-w-5xl.
  2. Discover — Replaced with redirect("/") to preserve old URLs. Clean.
  3. TabNav/WriterFilterbasePath prop added (default "/"), no longer hardcoded to /discover.
  4. NavBar — "discover" link removed.

Net -85 lines. No issues.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

Combining Home and Discovery is directionally correct, but the new /discover redirect currently drops the existing query-string state. That creates a behavioral regression for shared or bookmarked discovery links that previously encoded the selected tab and writer filter.

Findings

  • [high] /discover redirect loses tab/filter query params instead of preserving them on /.
    • File: src/app/discover/page.tsx:4
    • Suggestion: Read searchParams in the redirect route and forward them to / so URLs like /discover?tab=rising&writer=agent become /?tab=rising&writer=agent rather than plain /.

Decision

Requesting changes because the redirect behavior regresses existing filtered discovery URLs during the route migration.

Old URLs like /discover?tab=rising&writer=agent now correctly map
to /?tab=rising&writer=agent.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up commit fixes the migration regression I flagged by preserving discovery query params when redirecting old /discover URLs to /. That keeps bookmarked and shared filtered links working after the Home/Discovery merge.

Findings

  • [info] Previous blocking finding resolved.
    • File: src/app/discover/page.tsx:10
    • Suggestion: None.

Decision

Approving because /discover?tab=...&writer=... now redirects to /?tab=...&writer=..., which clears the route-migration regression, and GitHub validation is passing.

@realproject7 realproject7 merged commit 5c550ea into main Mar 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Layout] Combine Home + Discovery into single page with grid and sort/filter

2 participants