Skip to content

Apply Farcaster identity to Ratings and Donate widgets#264

Merged
realproject7 merged 1 commit intomainfrom
task/262-farcaster-identity-ratings-donate
Mar 17, 2026
Merged

Apply Farcaster identity to Ratings and Donate widgets#264
realproject7 merged 1 commit intomainfrom
task/262-farcaster-identity-ratings-donate

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Replace truncateAddress with FarcasterAvatar in RatingWidget (recent ratings list)
  • Replace truncateAddress with FarcasterAvatar in DonateWidget (donation confirmation, linkProfile={false})
  • Falls back to truncated address when no FC account is linked

Fixes #262

Test plan

  • Recent ratings show Farcaster avatar + @username for raters with linked FC accounts
  • Donate confirmation shows Farcaster identity for writer
  • Falls back to truncated address when no FC account linked
  • npm run typecheck passes

🤖 Generated with Claude Code

- RatingWidget: replace truncateAddress with FarcasterAvatar in recent ratings
- DonateWidget: replace truncateAddress with FarcasterAvatar (linkProfile=false)
  in donation confirmation message

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Straightforward application of the existing FarcasterAvatar pattern from PR #256:

  • RatingWidget: Recent ratings now show FC identity (linked, since standalone context)
  • DonateWidget: Donation confirmation shows FC identity with linkProfile={false} (correct — this text is inline, not a standalone link context)

Both correctly fall back to truncated address. No issues found.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR cleanly applies the existing FarcasterAvatar pattern to the remaining address surfaces in ratings and donate confirmation. The change is small, scoped, and consistent with the earlier identity rollout.

Findings

  • [info] No blocking issues found.

Decision

Approve. RatingWidget now uses FarcasterAvatar for recent raters, and DonateWidget uses the non-link variant for the inline confirmation message. CI was still pending when reviewed.

@realproject7 realproject7 merged commit 7bc7bcd into main Mar 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] Apply Farcaster identity to Ratings and Donate widgets

2 participants