Fix language 'All' filter reverting to English#276
Merged
realproject7 merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Always pass lang=all in URL when 'All languages' is selected, and accept 'all' as a valid lang param on the server side. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
realproject7
added a commit
that referenced
this pull request
Mar 26, 2026
Revert global Supabase cache:'no-store' per T2a review. Instead use Next.js connection() in the homepage component to opt that route out of the Data Cache while leaving other routes (story pages, OG, etc.) unaffected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realproject7
added a commit
that referenced
this pull request
Mar 26, 2026
Per T2a review: connection() is redundant since searchParams already makes the page dynamic. The actual fix is removing revalidate=120 (done in the first commit), which caused ISR to cache each filter combo's rendered output including stale DB query results. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realproject7
added a commit
that referenced
this pull request
Mar 26, 2026
Revert global Supabase cache:'no-store' per T2a review. Instead use Next.js connection() in the homepage component to opt that route out of the Data Cache while leaving other routes (story pages, OG, etc.) unaffected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realproject7
added a commit
that referenced
this pull request
Mar 26, 2026
Per T2a review: connection() is redundant since searchParams already makes the page dynamic. The actual fix is removing revalidate=120 (done in the first commit), which caused ISR to cache each filter combo's rendered output including stale DB query results. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realproject7
added a commit
that referenced
this pull request
Mar 26, 2026
* [#558] Fix stale language filter by disabling Next.js Data Cache Supabase PostgREST queries go through fetch(), which Next.js caches via its Data Cache. With revalidate=120, filtered query results (e.g. ?lang=English) served stale data after DB migrations updated language values. Adding cache:'no-store' to the server Supabase client ensures queries always hit the DB. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * [#276] Narrow cache bypass to homepage only via connection() Revert global Supabase cache:'no-store' per T2a review. Instead use Next.js connection() in the homepage component to opt that route out of the Data Cache while leaving other routes (story pages, OG, etc.) unaffected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * [#276] Remove redundant connection() — fix is removing revalidate Per T2a review: connection() is redundant since searchParams already makes the page dynamic. The actual fix is removing revalidate=120 (done in the first commit), which caused ISR to cache each filter combo's rendered output including stale DB query results. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.tsx: accept?lang=allas valid (re-apply PR Allow 'All languages' filter on discovery page #273 fix reverted by PR Custom styled dropdown for genre and language filters #274)GenreLanguageFilter.tsx: always includelangparam in URL when "All languages" selectedFixes #275
Test plan
🤖 Generated with Claude Code