[#296] Replace $ logo with SVG symbol in nav bar#299
Conversation
Swap the $ character for an <img> referencing /plotlink-logo-symbol.svg, sized at 18px and vertically aligned with the PlotLink text. Fixes #296 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Clean swap. <img> is fine for a small static SVG (no need for Next <Image>), alt="" correct for decorative symbol, align-middle on both elements keeps vertical alignment. LGTM.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The PR is correctly scoped to issue #296, but the implementation introduces a likely lint blocker in the nav component.
Findings
- [medium] Raw
<img>in a Next component is likely to fail this repo's lint config.- File:
src/components/NavBar.tsx:27 - Suggestion: Use
next/imagefor the logo asset, or inline the SVG if you want to avoid the@next/next/no-img-elementrule from the repo'seslint-config-next/core-web-vitalssetup.
- File:
Decision
Requesting changes because this implementation is likely to fail the existing lint gate before merge, even though the visual change itself matches issue #296.
Addresses T2a review: use next/image to satisfy @next/next/no-img-element lint rule. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The blocking lint issue is fixed, and the PR remains a minimal implementation of issue #296.
Findings
- No blocking findings.
Decision
Approving because the nav bar now uses next/image for the SVG symbol, preserves the home link behavior, and keeps the change narrowly focused on the requested logo replacement.
Previously untracked — referenced by NavBar (PR #299). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add helper text below "Opening Chapter" label explaining character limits and markdown support. Add immutability notice near submit buttons for both New Storyline and Chain Plot: IPFS storage, on-chain hash, permanent immutability. Styled with terminal aesthetic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace character limit copy with guidance on what the genesis plot is for: synopsis/introduction or jump straight into the story. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
$text character in the nav bar logo with an<img>referencing/plotlink-logo-symbol.svgalign-middle/preserved, no layout shiftFixes #296
Test plan
$character/🤖 Generated with Claude Code