Skip to content

[#296] Replace $ logo with SVG symbol in nav bar#299

Merged
realproject7 merged 2 commits intomainfrom
task/296-nav-svg-logo
Mar 18, 2026
Merged

[#296] Replace $ logo with SVG symbol in nav bar#299
realproject7 merged 2 commits intomainfrom
task/296-nav-svg-logo

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Replaced the $ text character in the nav bar logo with an <img> referencing /plotlink-logo-symbol.svg
  • Logo sized at 18×18px, vertically aligned with "PlotLink" text using align-middle
  • Link to / preserved, no layout shift

Fixes #296

Test plan

  • Verify SVG logo renders in nav bar instead of $ character
  • Verify vertical alignment with "PlotLink" text
  • Check mobile and desktop nav bar appearance
  • Confirm link still navigates to /

🤖 Generated with Claude Code

Swap the $ character for an <img> referencing /plotlink-logo-symbol.svg,
sized at 18px and vertically aligned with the PlotLink text.

Fixes #296

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean swap. <img> is fine for a small static SVG (no need for Next <Image>), alt="" correct for decorative symbol, align-middle on both elements keeps vertical alignment. LGTM.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The PR is correctly scoped to issue #296, but the implementation introduces a likely lint blocker in the nav component.

Findings

  • [medium] Raw <img> in a Next component is likely to fail this repo's lint config.
    • File: src/components/NavBar.tsx:27
    • Suggestion: Use next/image for the logo asset, or inline the SVG if you want to avoid the @next/next/no-img-element rule from the repo's eslint-config-next/core-web-vitals setup.

Decision

Requesting changes because this implementation is likely to fail the existing lint gate before merge, even though the visual change itself matches issue #296.

Addresses T2a review: use next/image to satisfy @next/next/no-img-element
lint rule.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The blocking lint issue is fixed, and the PR remains a minimal implementation of issue #296.

Findings

  • No blocking findings.

Decision

Approving because the nav bar now uses next/image for the SVG symbol, preserves the home link behavior, and keeps the change narrowly focused on the requested logo replacement.

@realproject7 realproject7 merged commit cad7046 into main Mar 18, 2026
1 check passed
realproject7 added a commit that referenced this pull request Mar 18, 2026
Previously untracked — referenced by NavBar (PR #299).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realproject7 added a commit that referenced this pull request Mar 27, 2026
Add helper text below "Opening Chapter" label explaining character
limits and markdown support. Add immutability notice near submit
buttons for both New Storyline and Chain Plot: IPFS storage, on-chain
hash, permanent immutability. Styled with terminal aesthetic.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realproject7 added a commit that referenced this pull request Mar 27, 2026
Replace character limit copy with guidance on what the genesis plot
is for: synopsis/introduction or jump straight into the story.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlotLink: Replace $ logo with SVG symbol in nav bar

2 participants