[#310] Filter bar polish: short labels, cleanup, overflow safety#311
Merged
realproject7 merged 1 commit intomainfrom Mar 18, 2026
Merged
[#310] Filter bar polish: short labels, cleanup, overflow safety#311realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
- Mobile labels shortened: W:, G:, L: (full labels on sm+) - Removed orphaned WriterFilter, GenreLanguageFilter, SortDropdown - Moved WriterFilterValue type into FilterBar - Added min-w-0 and overflow-x-auto for narrow-screen safety Fixes #310 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 18, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Clean cleanup. Short labels use correct responsive pattern (sm:hidden/hidden sm:inline). Orphaned components properly deleted, WriterFilterValue type preserved via re-export. Overflow safety with overflow-x-auto + min-w-0 is the right approach. LGTM.
project7-interns
approved these changes
Mar 18, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR completes the requested filter-bar polish and removes the orphaned components cleanly.
Findings
- No blocking findings.
Decision
Approving because mobile labels are shortened while desktop keeps the full labels, the unused legacy filter components are removed, the writer type is preserved via FilterBar, and the narrow-screen overflow safety is added without changing filter behavior.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
W:,G:,L:— desktop keeps fullwriter:,genre:,lang:WriterFilter.tsx,GenreLanguageFilter.tsx,SortDropdown.tsxWriterFilterValuetype moved intoFilterBar.tsxand re-exportedmin-w-0on token containers andoverflow-x-autoon the bar for narrow-screen safetyFixes #310
Test plan
W:All G:All L:English ↕writer:All genre:All lang:English sort:Recentnpm run typecheck)npm run lint)🤖 Generated with Claude Code