[#312] Clean up all ESLint errors and warnings#313
Merged
realproject7 merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
- Exclude packages/sdk/dist/ from linting (4 errors + 1 warning) - Remove unused `reset` destructuring in create/page.tsx - Remove unnecessary `tokenAddress` dep in ClaimRoyalties.tsx - Wrap `allOptions` in useMemo in Select.tsx npm run lint now exits with 0 errors and 0 warnings. Fixes #312 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 18, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
All four fixes are correct: dist exclusion, unused destructuring, unnecessary dep removal, and useMemo wrap. No functional changes. LGTM.
project7-interns
approved these changes
Mar 18, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR is tightly scoped to the pre-existing lint issues from issue #312 and does not introduce behavior changes.
Findings
- No blocking findings.
Decision
Approving because the eslint ignore is narrowed to compiled SDK output, the unused create-page destructuring is removed, the unnecessary callback dependency is gone without changing runtime behavior, and Select now memoizes allOptions as requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/sdk/dist/from ESLint config (resolves 4 errors + 1 warning from compiled output)resetdestructuring insrc/app/create/page.tsxtokenAddressdependency insrc/components/ClaimRoyalties.tsxallOptionsinuseMemoinsrc/components/Select.tsxnpm run lintnow exits with 0 errors and 0 warningsFixes #312
Test plan
npm run lintexits cleanly (0 errors, 0 warnings)npm run typecheckpassesnpm run buildpasses🤖 Generated with Claude Code