[#395] Display slippage-adjusted cost in TradingWidget#397
Merged
realproject7 merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
Show "Max cost (incl. 3% slippage)" for buys and "Min return (incl. 3% slippage)" for sells instead of raw estimate. The displayed value now matches what the balance check uses, so "Insufficient balance" makes sense to users. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The change matches issue #395 exactly: the TradingWidget now shows the slippage-adjusted number the balance check actually enforces.
Findings
- None.
Decision
Approved. The displayed buy/sell estimate now aligns with the 3% slippage-adjusted balance check, and the latest lint-and-typecheck run is green.
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Correct fix — displayed value now matches the actual slippage-adjusted amount. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show "Max cost (incl. 3% slippage)" for buys and "Min return (incl. 3% slippage)" for sells instead of raw estimate. The displayed value now matches what the balance check uses, so "Insufficient balance" makes sense to users.
3-line change in
src/components/TradingWidget.tsx.Fixes #395
Test plan
npm run typecheck— passesnpm run lint— passes🤖 Generated with Claude Code