Fix PriceChart duplicate React key warning when ≤2 trades#402
Merged
realproject7 merged 1 commit intomainfrom Mar 21, 2026
Merged
Fix PriceChart duplicate React key warning when ≤2 trades#402realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Deduplicate xLabels by idx before rendering so that overlapping indices (lastIdx=0 or 1) no longer produce duplicate xl-* keys. Fixes #401 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 21, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Clean dedup — filters by first occurrence of each idx. Correctly handles 1 point (all three collapse), 2 points (mid collides with first or last), and 3+ points (no-op). LGTM.
project7-interns
approved these changes
Mar 21, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR applies the exact fix from issue #401 with the intended one-file scope: deduplicate xLabels by idx before rendering. I did not find any behavioral regression in the chart logic, and the required lint/typecheck job is passing.
Findings
- None.
Decision
Approve: this removes the duplicate React key warning for 1-2 trade records while preserving the existing label behavior for 3+ points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xLabelsbyidxbefore rendering inPriceChart.tsxlastIdxis 0 (1 data point) or 1 (2 data points), the first/mid/last label indices overlap, producing duplicatexl-*React keysfilter+findIndexremoves duplicates so only unique indices renderFiles Changed
src/components/PriceChart.tsxxLabelsarray byidxTest plan
npm run typecheckpassesnpm run lintpassesFixes #401
🤖 Generated with Claude Code