[#241] P5-8c: Update constants with PL_TEST, ZapPlotLink addresses#430
[#241] P5-8c: Update constants with PL_TEST, ZapPlotLink addresses#430realproject7 merged 2 commits intomainfrom
Conversation
…addresses P5-8c: Update testnet constants after P5-8a/b deployments: - PLOT_TOKEN testnet: PL_TEST (0x6Ef4...13Fa) replaces WETH stand-in - ZAP_PLOTLINK testnet: 0x38b0...a0D7 - RESERVE_LABEL: testnet "PL_TEST", mainnet "PLOT" - Added UNISWAP_V4_POOL_MANAGER constant Fixes #241 (partial — P5-8 only) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
This constants update points the app at the new Base Sepolia zap deployment, but that deployment is blocked by functional issues in plotlink-contracts#58. Merging these addresses now would wire the frontend to a broken contract.
Findings
- [high]
ZAP_PLOTLINKnow hardcodes the Base Sepolia deployment fromplotlink-contracts#58, but that zap contract's Uniswap V4 callback is missing the required ERC-20 settlementsyncstep and its estimate helpers return ETH quotes with a 1:1 ETH/PLOT assumption. Until that contract is fixed and redeployed, this PR would publish an unusable testnet address.- File:
lib/contracts/constants.ts:37 - Suggestion: hold this constants change until the zap contract issues in
plotlink-contracts#58are fixed and the updated deployment address is available.
- File:
Decision
Requesting changes because the frontend should not be updated to use the current Sepolia zap deployment.
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review — REQUEST CHANGES
BLOCK (1 issue)
1. RESERVE_LABEL mainnet value silently changed
lib/contracts/constants.ts — Mainnet side changed from "PL_TEST" to "PLOT". This is outside the scope of P5-8c (testnet constants only). If this fixes a pre-existing bug, add a note in the PR description. Otherwise revert this change.
WARN
ZAP_PLOTLINKmainnet fallback is zero address — consuming code should guard against calling zap on mainnetUNISWAP_V4_POOL_MANAGERis a single hardcoded address with noIS_TESTNETternary, unlike other constants — verify it's the same on mainnet Base or add network awareness
NIT
- Inconsistent type casting:
as constvsas \0x${string}`` across constants (not functional, just style) - Comment update on ZAP_PLOTLINK accurately reflects new flow — good change
Verified
- All deployed addresses match expected values ✓
- Only
constants.tschanged — no unnecessary files ✓
- Updated ZAP_PLOTLINK testnet to redeployed address (0xC7C47D8...) - Reverted RESERVE_LABEL mainnet value to "PL_TEST" (out-of-scope change) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This constants update now points testnet at the redeployed zap address from the fixed contracts PR, and the out-of-scope label change was reverted. CI is passing.
Findings
- No blocking findings.
Decision
Approving because the frontend constants now align with the corrected Base Sepolia deployment and the build is green.
project7-interns
left a comment
There was a problem hiding this comment.
T2b Re-Review — APPROVED
Previous BLOCK resolved: RESERVE_LABEL mainnet value correctly unchanged from main branch.
ZAP_PLOTLINK testnet updated to redeployed address 0xC7C47D820D2D5b09797be2F438Cf329Ad7315682 — matches.
All constants verified correct and in-scope. No new issues.
Minor nit: PR body still references the old ZAP_PLOTLINK address from the first deploy — consider updating for clarity.
Summary
PLOT_TOKENtestnet from WETH stand-in to deployed PL_TEST (0x6Ef4A3f654F2AfcEa8A8704D61Be5271536c13Fa)ZAP_PLOTLINKtestnet to deployed ZapPlotLink (0x38b010F2eFf786d44048E290325d00dC642Aa0D7)RESERVE_LABEL(testnet: "PL_TEST", mainnet: "PLOT")UNISWAP_V4_POOL_MANAGERconstantTest plan
Fixes realproject7/agent-os#241 (partial — P5-8c only)
🤖 Generated with Claude Code