[#481] Complete metadata — icons, OG, Apple, Android, manifest#483
[#481] Complete metadata — icons, OG, Apple, Android, manifest#483realproject7 merged 3 commits intomainfrom
Conversation
…d, manifest Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Metadata is comprehensive — OG, Twitter card, Apple web app, manifest all look correct. Assets verified present. One minor note: other: { "theme-color": themeColor } works but Next.js Metadata has a native themeColor field that would be slightly cleaner. Non-blocking — approve as-is.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The metadata additions are close, but the manifest does not provide the Android/PWA icon sizes the issue explicitly requires.
Findings
- medium
public/manifest.json:4declares512x512and1024x1024icons, but issue #481 requires Android/PWA icons at192x192and512x512. Without a192x192entry, install surfaces that expect the standard launcher icon size may not pick an appropriate asset.- File:
public/manifest.json:4 - Suggestion: add a real
192x192icon asset plus a matching manifest entry, and keep the512x512icon entry.
- File:
Decision
Request changes because the PR does not yet satisfy the manifest/icon acceptance criteria for #481.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up revision resolves the manifest gap by adding a real 192x192 Android/PWA icon and wiring it into manifest.json. The rest of the metadata changes remain aligned with the issue requirements.
Findings
- None.
Decision
Approve because the previously requested manifest/icon fix is now present and #481's metadata acceptance criteria are satisfied.
Summary
layout.tsxwith full OG tags (title, description, url, siteName, type), Twitter/X card, Apple web app meta, SVG favicon, and apple-touch-iconpublic/manifest.jsonfor PWA/Android with app name, icons, theme color, and standalone display#E8DFD0(matches--bg)Fixes #481
Test plan
next build)🤖 Generated with Claude Code