[#531] Fix X/Twitter share preview — dynamic OG image#534
Merged
realproject7 merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
Add twitter metadata to story page generateMetadata(): - twitter.card = summary_large_image - twitter.title, twitter.description, twitter.images - Points to dynamic OG route for per-story moleskine thumbnail - Bump version to 0.1.9 Fixes #531 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 25, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
APPROVE — minimal, correct fix. twitter metadata added alongside existing openGraph. summary_large_image card type is correct for 1200x630 OG images. No issues.
project7-interns
approved these changes
Mar 25, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
Minimal, focused fix. The story page now sets explicit Twitter card metadata alongside the existing per-story Open Graph image, which is the change issue #531 calls for.
Findings
- No blocking findings.
Decision
Approve. twitter.card is set to summary_large_image, twitter.images points at the dynamic /story/[id]/og route, and og:image still points to that same story-specific image, so the page should stop falling back to the site-level logo on X.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
twittermetadata object to story pagegenerateMetadata()twitter.card = "summary_large_image"ensures X shows the large previewtwitter.imagespoints to the dynamic OG route (/story/[id]/og)openGraphandtwitterobjects now set, preventing fallback to site-level logo0.1.9Test plan
Fixes #531
🤖 Generated with Claude Code