Skip to content

[#555] Persist language filter in localStorage #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realproject7 merged 2 commits into from
Mar 26, 2026
Merged

[#555] Persist language filter in localStorage #557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58d51e9
[#555] Persist language filter in localStorage
realproject7 Mar 26, 2026
c915cff
[#275] Check URL param presence instead of normalized value
realproject7 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/components/FilterBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,25 @@ export function FilterBar({ writer, genre, lang, tab }: FilterBarProps) {
return () => document.removeEventListener("mousedown", handleClick);
}, []);

// Restore saved language preference on first visit (no lang param in URL)
useEffect(() => {
const urlParams = new URLSearchParams(window.location.search);
if (urlParams.has("lang")) return; // explicit param — don't override
try {
const saved = localStorage.getItem("plotlink_lang");
if (saved && saved !== "all" && (LANGUAGES as readonly string[]).includes(saved)) {
router.replace(buildHref({ tab, writer, genre, lang: saved }));
}
} catch {}
}, []); // eslint-disable-line react-hooks/exhaustive-deps

function toggle(key: FilterKey) {
setOpen(open === key ? null : key);
}

function navigate(params: { tab: string; writer: string; genre: string; lang: string }) {
setOpen(null);
try { localStorage.setItem("plotlink_lang", params.lang); } catch {}
router.push(buildHref(params));
}

Expand Down
Loading