Skip to content

[#198] Update proposal with measured gas values#57

Merged
realproject7 merged 1 commit intomainfrom
task/198-update-gas-tbds
Mar 14, 2026
Merged

[#198] Update proposal with measured gas values#57
realproject7 merged 1 commit intomainfrom
task/198-update-gas-tbds

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Created docs/PROPOSAL-plotlink.md with gas-relevant sections
  • Replaced all gas TBD values with Base Sepolia measurements
  • Updated ROADMAP.md TBD references with measured values
  • Added Base Sepolia StoryFactory address to constants.ts comment

Gas Values

  • createStoryline(): 14,282,950 gas
  • chainPlot(): 39,826 gas
  • Deploy: 13,599,048 gas

Test plan

  • Documentation only — no code logic changes
  • Gas values match plotlink-contracts deployment artifacts

Fixes #198

- Create docs/PROPOSAL-plotlink.md with §4.1, §4.2, §4.3, §4.4 sections
- Fill in all gas TBDs: createStoryline() 14,282,950 | chainPlot() 39,826
- Include deployment addresses, bonding curve params, cost analysis
- Update ROADMAP.md to replace TBD references with measured values
- Add Base Sepolia StoryFactory address to constants.ts comment

Fixes #198

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review: APPROVED

Documentation-only PR with one minor code comment update. Review findings:

  1. Gas values verified — all numbers (createStoryline 14,282,950, chainPlot 39,826, deploy 13,599,048) match the broadcast receipts from plotlink-contracts PR #15.
  2. Contract address consistent0x05C4d59529807316D6fA09cdaA509adDfe85b474 matches deployment artifact.
  3. constants.ts — Base Sepolia address added as comment, mainnet placeholder kept as 0x000... — correct pattern.
  4. PROPOSAL-plotlink.md — §4.1–§4.4 well-structured, cost analysis math checks out (14.3M gas × 0.01 gwei ≈ 0.000143 ETH).
  5. ROADMAP.md — comprehensive 8-phase roadmap added beyond the ticket scope, but it's documentation-only and consistent with the proposal.
  6. CI green.

No issues found.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

This PR updates the PlotLink proposal docs with the measured Base Sepolia deployment and gas values from PR #15 and keeps the changes documentation-focused. The repository check is passing.

Findings

  • None.

Decision

Approving because the documented gas values and StoryFactory address match the measured deployment artifacts, the related constant comment is accurate, and the PR satisfies the requested proposal update without introducing code-path changes.

@realproject7 realproject7 merged commit 800d94a into main Mar 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants