Skip to content

Add Agent Identity card to profile trust dashboard#592

Merged
realproject7 merged 2 commits intomainfrom
task/585-agent-profile-display
Mar 27, 2026
Merged

Add Agent Identity card to profile trust dashboard#592
realproject7 merged 2 commits intomainfrom
task/585-agent-profile-display

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

Fixes #586

  • New Agent Identity card in the profile trust dashboard grid for registered agents (writer_type=1)
  • Displays: Agent ID, name, description, LLM model, genre, registration date
  • Shows owner wallet link when different from the bound agent wallet (cross-wallet visibility)
  • Extends AgentMetadata interface with agentId and owner fields, fetched in parallel via ownerOf()
  • Non-agent profiles completely unaffected — card only renders when isAgent && agentMeta is truthy
  • Matches existing trust dashboard card styling (border-border, text sizing, label/value pattern)

Test plan

  • Visit an agent profile → Agent Identity card appears with all available fields
  • Visit a human profile → no Agent Identity card
  • Agent with owner different from bound wallet → "Owner" row shows with link
  • Agent where viewer IS the owner → "Owner" row omitted
  • Build passes

🤖 Generated with Claude Code

Display full agent metadata (ID, name, description, model, genre,
registration date, owner when different from bound wallet) in a new
trust dashboard card for writer_type=1 profiles. Extends AgentMetadata
interface with agentId and owner fields, fetched in parallel from the
ERC-8004 registry. Non-agent profiles unaffected.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Mar 27, 2026 2:42pm

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The new card layout is close, but the metadata lookup still fails for a class of valid ERC-8004 agents, so the feature does not reliably render for all registered agents.

Findings

  • [medium] Profile pages still treat non-JSON agentURI values as "not an agent".
    • File: lib/contracts/erc8004.ts:230
    • Suggestion: reuse the URI-resolution logic already added in AgentManage (data:, https://, ipfs://, raw JSON) when resolving getAgentMetadata(). Right now JSON.parse(uri as string) throws for valid external-agent URIs, getAgentMetadata() returns null, and /profile/[address] then hides both the AI Agent state and the new Agent Identity card for those registered agents.

Decision

Request changes. The presentation work is good, but the metadata loader still excludes valid cross-app ERC-8004 agents from the profile dashboard.

Move URI resolution logic (raw JSON, data:, https://, ipfs://) into a
shared resolveAgentURI() function in erc8004.ts. Used by both
getAgentMetadata (server-side) and AgentManage (client-side) so
agents registered via other apps with non-JSON URIs display correctly
everywhere.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up fix closes the remaining gap from my previous review. getAgentMetadata() now resolves raw JSON, data:, https://, and ipfs:// agent URIs through a shared helper, so the new Agent Identity card can render for valid cross-app ERC-8004 agents as well.

Findings

  • No blocking issues found in the updated changes.

Decision

Approve. The PR now satisfies issue #586's profile-card requirements without excluding external-agent registrations.

@realproject7 realproject7 merged commit f7ef1ac into main Mar 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display full AI agent metadata on profile page

2 participants